refactor(mqlaunch): de-layer the GitHub repo picker into a lib (Step 11a)#47
Merged
Merged
Conversation
…Step 11a) Pull run_github_repo_picker (fzf over `gh repo list` + open/clone action menu) out of the mqlaunch.sh monolith into mqlaunch/lib/repo-picker.sh, sourced back into the launcher's scope. Verbatim move: still uses the ambient UI helpers and $HOME/$SHELL; callers (main dispatch + command-mode's `declare -f … ` guard) resolve because the lib sources before dispatch. No behavior change. Pure bash, covered by shellcheck. Launcher: 1457 → 1348 lines (~720 out since 11a began). The launcher's mislabeled "# Opens repo browser." comment above the function is corrected to an accurate one in the lib; the function body is unchanged. Smoke CONCERNS row added (32 functions across 5 libs); AUTHORITY_MAP and CHANGELOG updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sixth slice of Step 11a (monolith de-layering, audit P4). Pull
run_github_repo_pickerout ofterminal/launchers/mqlaunch.shintomqlaunch/lib/repo-picker.sh— fzf overgh repo list, then an action menu (open in browser / cd into repo / clone to~/repos, optionally opening in VS Code or Finder).$HOME/$SHELL. No behavior change.declare -f …guard).Also corrects the launcher's mislabeled
# Opens repo browser.comment above the function (a copy-paste fromopen_repo_browser) to an accurate one in the lib — the function body itself is unchanged.Guard
Added the repo-picker row to
tests/monolith-delayer-smoke.sh— now 32 functions across 5 concern libs.Verification
Full selftest suite green (146 shell files lint clean); shellcheck clean on the new lib; resolution smoke confirms the function resolves after sourcing; markdownlint clean.
Part of the
v2.0.0runtime-authority track.🤖 Generated with Claude Code